Repository navigation
rewrite: bound OpenCode service discovery and model lookup by the rewrite deadline - #1442
Merged
Merged
Conversation
A rewrite's caller-supplied deadline and cancellation flag now cover service discovery (/api/info) and the ranked catalog read (/api/model), each still capped by its existing per-request timeout. Settings catalog and availability checks keep their fixed timeouts. A cancelled or timed-out catalog read caches nothing, like any other lookup failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ai rewrite and voice action generation applied their deadline and cancellation only to generation itself. opencode discovery (
/api/info, fixed 2s per registration) and the uncached model catalog read (/api/model, fixed 10s) ignored both, so a stalled service could delay fallback well past the configured timeout.now both lookups use
min(remaining budget, existing cap)and honor the caller's cancel flag. other callers (settings catalog, availability checks) keep their fixed timeouts. a cancelled or timed-out catalog read caches nothing, same as any other catalog failure.tests added:
a_service_search_is_bounded_by_the_callers_deadlinea_service_search_stops_when_the_caller_cancelsa_generation_without_time_or_after_cancellation_fails_promptlya_cancelled_catalog_lookup_returns_nothing_and_caches_nothingfixes #1435
credit to @0x00-sys for the detailed report and the suggested approach.