Repository navigation
Conversation
With Hex stopped, `hex model install` downloaded and verified the model but never wrote the selection, so `model status`, `check`, and `transcribe` kept using the previous one, and no message said so. The offline branch now selects it as the app's own switch would: a Hex that started while the download ran takes the choice over `model use`, otherwise the selection is saved under the Linux service lock `settings apply` uses, so a starting Hex is never written behind. An already selected model is left alone, so login-time installs don't rewrite settings.json. Docs say the offline install selects now, and a new app_settings test covers the persisted round trip keeping unrelated settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with Hex stopped on Linux/Windows,
hex model install <id>downloaded and verified the model but never saved it as the selected model, somodel statusandmodel transcribekept using the old one.now it saves the selection the same way the app does (under the service lock on Linux, skipped when already selected), hands the choice to a Hex that started during the download, and docs say so.
Fixes #1429
Checks: