Repository navigation
Conversation
Member
|
Update X6 to version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evaluator pins X6 3.1.7 while the skill and reference examples use container ID strings, causing
TypeError: t.cloneNode is not a functionat initialization. X6 3.1.8 supports DOM IDs (antvis/X6#5087), so upgrading the evaluator allows the existing examples to initialize.This change pins the evaluator and introductory CDN example to X6 3.1.8 and documents both valid container forms: an existing DOM ID or an
HTMLElement. It limits the variable-redeclaration warning to hosts that already provide the same binding. It also fixes the CDN filename, supplies a sized container in the HTML example, corrects the80 0typo, and synchronizes the skill catalog descriptions. All 136 reference records are retained byte-for-byte from upstream.Validation:
npm test: all 14 tests passed.npm run build: retrieval indexes rebuilt and TypeScript compilation passed.dist/x6.jsreturns HTTP 404;dist/x6.min.jsreturns HTTP 200.Graph.registerHTMLComponenterror in both versions. This check covers initialization, not full rendering of every reference.git diff --check: passed.Generated with AI assistance.