Improve Property Types

[Amemeda]

• Moved required properties out of ServerConfigCheckRunner.java and into Property.java as a final static enum Set REQUIRED_PROPERTIES to match the implementation of FIXED_PROPERTIES, added more detailed Javadoc to the method.
• Added validation and PropertyType.URI
• Removed outdated TODO from PropertyType.java

This pr resolves #6112
Refer to discussion over property types on pr #5348

[Amemeda]

@kevinrr888 Checking if you are still available for discussion on this issue, Looking for your guidance/opinion over the expected changes

[Amemeda]

@ctubbsii Proposal for additional PropertyType.STRING validation:

Found groups of Properties of PropertyType.STRING that could potentially have new PropertyType:

create new PropertyType.PASSWORD (is password unique enough to need its own validation? Can a password be empty/null) for validating a password for these Properties:

• Property.RPC_SSL_KEYSTORE_PASSWORD
• Property.RPC_SSL_TRUSTSTORE_PASSWORD
• Property.MONITOR_SSL_KEYSTOREPASS
• Property.MONITOR_SSL_KEYPASS
• Property.MONITOR_SSL_TRUSTSTOREPASS

create new PropertyType.ADDRESS (or IP) for validating if a string is a valid IP format (ex: 0.0.0.0)

• Property.RPC_PROCESS_ADVERTISE_ADDRESS
• Property.GENERAL_PROCESS_BIND_ADDRESS
• Property.RPC_PROCESS_BIND_ADDRESS

Probably unnecessary since it looks like there is a list of enabled protocols server side that the protocol must match. Create new PropertyType.PROTOCOL (what does protocol look like) for validating a protocol for this group of Property:

• Property.RPC_SSL_CLIENT_PROTOCOL
• Property.RPC_SSL_ENABLED_PROTOCOLS
• Property.MONITOR_SSL_INCLUDE_PROTOCOLS

---

Alternative validation for these Properties that are PropertyType.STRING can be done by creating a new ValidString() method for the PropertyType.STRING. ValidString() can check for the specific string cases mentioned above, and return true for all other strings, currently all Properties of PropertyType.STRING always returns true to validate a string

[ctubbsii]

This validation for URI type is good, but I don't think we need to log the error. Returning false achieves the same effect, and will report to the user that it is not a valid URI type.

[Amemeda]

Included the log error for consistency with the other validate methods, some also log the error then return false. I can still remove if needed

[ctubbsii]

This comment that was removed suggests that we should not check input == null here, but should use Predicates.or(Predicates.isNull(), ...) for any patterns where we want to allow null.

If we leave the input == null here, then we need to do something like Predicates.and(Predicates.isNull().negate(), ...) for required properties.

I'm not sure if we've done either, or which would be easier to do if we haven't.

[Amemeda]

I reviewed this TODO with Dom, and he said the required properties check in ServerConfigCheckRunner is already doing this/ or something close