perf(parquet): decode levels directly into int16 batches - #1176
Merged
zeroshade merged 1 commit intoAug 28, 2026
Merged
Conversation
fallintoplace
marked this pull request as draft
August 11, 2026 21:46
fallintoplace
marked this pull request as ready for review
August 18, 2026 18:21
zeroshade
approved these changes
Aug 28, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM. The direct int16 level-decoding path preserves RLE and bit-packed semantics across partial reads, maximum levels, split decoding, and malformed inputs. Package tests, race tests, the full Parquet suite, randomized differential probes, benchmarks, and CI all pass.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Arrow Go maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Arrow Go handles maintainer review:
CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
[]int16uint64level batch and its second conversion passBenchmarks
Apple M1 Pro,
-benchtime=300ms -count=5:Allocations were unchanged.