perf(arrow/array): validate dictionary indices by valid runs - #1181
Open
fallintoplace wants to merge 1 commit into
Open
perf(arrow/array): validate dictionary indices by valid runs#1181fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
marked this pull request as draft
August 12, 2026 11:08
fallintoplace
marked this pull request as ready for review
August 18, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The current bounds check scans every physical index, including null positions. This does unnecessary work for clustered nullable arrays and can reject garbage payloads that are hidden by the validity bitmap.
The existing TODO points to the set-bit run reader for this case. This change uses it for up to eight valid runs. More fragmented bitmaps keep the vectorized whole-slice fast path. If that scan finds an invalid physical value, valid runs are checked again so null payloads are still ignored.
Benchmark
1M int32 indices on an Apple M1 Pro, 300 ms per sample, 6 samples:
All cases remain at 0 allocations/op.
Checks
go test ./arrow/...go vet ./arrow/arraygit diff --checkNo public API changes.