perf(arrow/array): batch run-end encoded appends - #1214
Merged
Conversation
zeroshade
approved these changes
Aug 26, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
Reviewed at fa9d776. The bulk append implementation preserves logical behavior while reducing repeated null/empty appends to a single physical run. The full arrow/array suite, race tests, semantic equivalence probes, boundary coverage, formatting, vet, and diff hygiene all passed locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RunEndEncodedBuilder.AppendNullsinto one physical null value and one run.RunEndEncodedBuilder.AppendEmptyValuesinto one physical empty value and one run.The old implementation called the scalar append method once per logical value. This change keeps the same API while avoiding the repeated physical values and run ends.
Benchmark
Apple M1 Pro, 65,536 rows,
int32run ends andint32encoded values:The benchmark covers
int16,int32, andint64run-end types,int32and string encoded values, and multiple batch sizes.Tests
go test ./arrow/array -count=1go test ./... -run '^$' -count=1 -p 2