Skip to content

fix(ci): use master Docker image for v2.5 branch only #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruojieranyishen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ci): use master Docker image for v2.5 branch only #2395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions .github/workflows/lint_and_test_cpp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
# specific language governing permissions and limitations
# under the License.

# NOTE: Docker images use 'master' branch tag for release branches (e.g., v2.5)
# that may not have prebuilt Docker images. Other branches use their own images.

name: Cpp CI

on:
Expand Down Expand Up @@ -64,7 +67,8 @@ jobs:
USE_JEMALLOC: OFF
ENABLE_ASAN: OFF
container:
image: apache/pegasus:thirdparties-bin-ubuntu2204-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
steps:
- name: Install Softwares
run: |
Expand All @@ -91,7 +95,8 @@ jobs:
USE_JEMALLOC: OFF
ENABLE_ASAN: OFF
container:
image: apache/pegasus:thirdparties-bin-ubuntu2204-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
steps:
- uses: actions/checkout@v4
- name: Free Disk Space (Ubuntu)
Expand Down Expand Up @@ -123,7 +128,8 @@ jobs:
ARTIFACT_NAME: release
BUILD_OPTIONS: -t release --test
container:
image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
steps:
- name: Clone code
uses: actions/checkout@v4
Expand Down Expand Up @@ -193,7 +199,8 @@ jobs:
env:
ARTIFACT_NAME: release
container:
image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
options: --cap-add=SYS_PTRACE
steps:
- uses: actions/checkout@v4
Expand All @@ -213,7 +220,8 @@ jobs:
ARTIFACT_NAME: release_address
BUILD_OPTIONS: --sanitizer address --disable_gperf --test
container:
image: apache/pegasus:thirdparties-bin-test-asan-ubuntu2204-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-test-asan-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
steps:
- uses: actions/checkout@v4
- name: Rebuild thirdparty if needed
Expand Down Expand Up @@ -284,7 +292,8 @@ jobs:
env:
ARTIFACT_NAME: release_address
container:
image: apache/pegasus:thirdparties-bin-test-asan-ubuntu2204-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-test-asan-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
options: --cap-add=SYS_PTRACE
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -394,7 +403,8 @@ jobs:
ARTIFACT_NAME: release_jemalloc
BUILD_OPTIONS: -t release --use_jemalloc --test
container:
image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu2204-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
steps:
- uses: actions/checkout@v4
- name: Rebuild thirdparty if needed
Expand All @@ -417,7 +427,8 @@ jobs:
env:
ARTIFACT_NAME: release_jemalloc
container:
image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu2204-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
options: --cap-add=SYS_PTRACE
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -472,7 +483,8 @@ jobs:
BUILD_OPTIONS: -t debug --test --separate_servers
PACK_OPTIONS: --separate_servers
container:
image: apache/pegasus:thirdparties-bin-rockylinux9-${{ github.base_ref }}
# Use master image for v2.5 branch (which lacks prebuilt images), others use their own
image: apache/pegasus:thirdparties-bin-rockylinux9-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}
steps:
- name: Clone code
uses: actions/checkout@v3
Expand Down
Loading