Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit thirdparty build dependency from RocksDB to Hadoop.
RocksDB builds the HDFS plugin on Linux, and that plugin includes hdfs.h from the
Hadoop native client output. Without a CMake ExternalProject dependency, RocksDB
and Hadoop can build in parallel, causing RocksDB to compile before Hadoop has copied
hdfs.h into thirdparty/output/include/hdfs.
This fixes intermittent thirdparty Docker build failures such as:
fatal error: hdfs.h: No such file or directory
Validation: