values not being respect in values.yaml file

[zyue110026]

We have noticed five instances of incorrect helming in your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

grafana.imagePullPolicy, elasticsearch.service.type, elasticsearch.service.nodePort, elasticsearch.service.loadBalancerIP, and elasticsearch.service.loadBalancerSourceRanges are not take affect when change their values to others. This is due to missing implementation for this value in grafana-pod.yaml file:

openwhisk-deploy-kube/helm/openwhisk/templates/grafana-pod.yaml

Line 65 in 5a5a216

image: "{{- .Values.docker.registry.name -}}{{- .Values.grafana.imageName -}}:{{- .Values.grafana.imageTag -}}"

and elasticsearch-svc.yaml:

openwhisk-deploy-kube/helm/openwhisk/templates/elasticsearch-svc.yaml

Lines 32 to 37 in 5a5a216

	spec:
	clusterIP: None # This is needed for statefulset hostnames like elasticsearch-0 to resolve
	# Create endpoints also if the related pod isn't ready
	publishNotReadyAddresses: true
	selector:
	name: {{ .Release.Name }}-elasticsearch

Expected Behavior

These values should take affect when changing them or delete them from values.yaml file

Actual Behavior

All values mentioned in this issue are not being respect.