fix(validation): report schema errors for invalid YAML - #271
Open
mattfaltyn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matt Faltyn <faltyn.matthew@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSON Schema validation already detects invalid YAML shapes, but the CLI continued into semantic checks that assume schema-valid mappings and lists. Those checks could raise
AttributeErrorbefore the existing reporter displayed the schema errors.This change:
The specification, CLI arguments, and dependency set are unchanged.
Related Issues
Closes #270
Testing
Focused validation
Results:
Repository-wide validation
go build,go vet, andgo testpass.verifybuilds pass.8c410f9); this PR does not modify Omni or the shared example.validation/**, so this PR has no remote checks.Checklist
Validation
Documentation
Tests
Compliance