Updating CI Actions path - #276
Conversation
|
@khush-bhatia @jbonofre adding this PR since I noticed CI failing for #259. LMK what you think. |
Hello @sfc-gh-swalia, Yes, this was implicitly added by me. The original idea is if there are composite actions (e.g. license , we should re-test all. I am fine with keep it restrict as one failure will now trigger all PR to halt. Thanks, |
|
The Omni CI failure here isn't from this PR. This PR only narrows the CI path filters, but editing converter-omni-ci.yml triggers the Omni CI, and that surfaces a pre-existing bug on main. What happens: #113 added a datatype field to Field/Metric and to examples/tpcds_semantic_model.yaml, but it never touched converters/omni, so the Omni converter doesn't know about datatype. On the OSI -> Omni -> OSI roundtrip the field gets dropped, and the result no longer matches the original. That breaks test_osi_roundtrip_up_to_documented_normalizations and test_tpcds_export_matches_expected. It slipped in because #113 changed neither converters/omni nor .github, so Omni CI never ran for it. The path change in this PR is fine. We just need a separate fix to make the Omni converter carry datatype through the conversion (and refresh the tpcds_omni fixture) to get this green. |
Summary
While working on PR #259, I noticed that all 8 converter CI workflows use .github/** as a path trigger. This means any PR that touches anything under
.github/triggers every converter's test suite unnecessarily.This wastes CI resources and creates confusing failures on unrelated PRs (e.g., #259 showed a failing Omni build that had nothing to do with the docs changes).
This fix narrows each workflow's path filter to only reference its own workflow file, so a converter's CI only runs when its converter code or its own workflow definition changes.
Related Issues
#259