PHOENIX-7949 IndexScrutinyWithMaxLookbackIT scrutiny at SCN beyond max lookback counts updated rows as VALID - #2560
Open
apurtell wants to merge 1 commit into
Open
PHOENIX-7949 IndexScrutinyWithMaxLookbackIT scrutiny at SCN beyond max lookback counts updated rows as VALID#2560apurtell wants to merge 1 commit into
apurtell wants to merge 1 commit into
Conversation
…x lookback counts updated rows as VALID Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates max-lookback scrutiny integration tests to reflect correct covered-column update behavior.
Changes:
- Isolates the test class in its own mini-cluster.
- Replaces incorrect beyond-lookback expectations with valid-row assertions.
- Documents SCN and compaction behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexScrutinyWithMaxLookbackITupdated only the covered column of a row and expected scrutiny to count it asBEYOND_MAX_LOOKBACK, but an in-place covered column update leaves the indexed column and thus the index row key unchanged, so the index row is never deleted. Major compaction retains the pre-update version as the row version visible at the lower edge of the max lookback window, andIndexScrutinyToolrefuses to scan at an SCN older than max lookback. The fix adds@Category(NeedsOwnMiniClusterTest.class)and replaces the two invalid test cases withtestScrutinyOnUpdatedRowsWithinMaxLookbackAreValidandtestScrutinyOnUpdatedViewIndexRowsWithinMaxLookbackAreValid, which assert the correct invariants with the rationale documented in inline comments, while leavingtestScrutinyOnDeletedRowsBeyondMaxLookBackunchanged.