RANGER-5708 : Correct early publication of KnoxRangerPlugin in Ranger - #1121
Open
rgupta94 wants to merge 1 commit into
Open
RANGER-5708 : Correct early publication of KnoxRangerPlugin in Ranger#1121rgupta94 wants to merge 1 commit into
rgupta94 wants to merge 1 commit into
Conversation
rameeshm
approved these changes
Jul 31, 2026
rgupta94
marked this pull request as ready for review
August 3, 2026 06:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a race in RangerPDPKnoxFilter where the static KnoxRangerPlugin instance was published before init() finished.
Previously, plugin was assigned immediately after construction, and plugin.init() ran afterward. When multiple Knox topologies initialized the filter concurrently, another thread could observe a partially initialized plugin and use it for authorization.
This change assigns the new plugin to a local variable, calls init() on that instance, and only then sets the static plugin field. That keeps the singleton fully initialized before it is visible to other threads.
Also adds a unit test to verify that concurrent filter initialization blocks until the first plugin finishes initializing.