Skip to content

fix(postgresql): filter PITR archive roots - #3406

Draft
weicao wants to merge 2 commits into
easton/pg-pitr-restore-dual-data-dirfrom
easton/pg-pitr-restore-root-filter
Draft

fix(postgresql): filter PITR archive roots#3406
weicao wants to merge 2 commits into
easton/pg-pitr-restore-dual-data-dirfrom
easton/pg-pitr-restore-root-filter

Conversation

@weicao

@weicao weicao commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What

Filter PITR repository root listings to slash-terminated archive directories before child traversal.

Why

An unrelated root object ordered before a valid archive directory was treated as a directory; its list failure aborted fetch before the required WAL and handoff.

Tests

  • RED f454e8984: Bash 3.2 focused 21 examples / 1 failure / 4 assertions
  • GREEN: Bash 3.2 focused 21/0; Bash 5.3 PostgreSQL full 289/0
  • Static/chart gates clean; render 41 docs / 1,014,408 bytes

@weicao
weicao requested review from a team, ldming and leon-ape as code owners August 17, 2026 01:16
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (98a900a) to head (38f376c).

Files with missing lines Patch % Lines
...ns/postgresql/scripts-ut-spec/pitr_restore_spec.sh 0.00% 14 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           easton/pg-pitr-restore-dual-data-dir   #3406   +/-   ##
====================================================================
  Coverage                                  0.00%   0.00%           
====================================================================
  Files                                       195     195           
  Lines                                     28416   28430   +14     
====================================================================
- Misses                                    28416   28430   +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weicao
weicao marked this pull request as draft August 17, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants