Skip to content

fix(hugegraph): fail server start if Store health never succeeds - #3418

Merged
weicao merged 1 commit into
dev/hugegraph-release-1.0from
feat/hugegraph-server-wait-store-failclosed
Aug 19, 2026
Merged

fix(hugegraph): fail server start if Store health never succeeds#3418
weicao merged 1 commit into
dev/hugegraph-release-1.0from
feat/hugegraph-server-wait-store-failclosed

Conversation

@weicao

@weicao weicao commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Child PR into dev/hugegraph-release-1.0. Official order is PD healthy -> Store -> Server. Server exported STORE_REST but did not wait, so it could start against a down Store.

Wait for Store /v1/health on 8520 and fail closed after the bounded wait. Attempts/sleep are overridable for tests.

Test

bash addons/hugegraph/tests/start_server_test.sh
bash addons/hugegraph/tests/contract_test.sh
HugeGraph addon offline contracts passed

Main PR: #3412
Sibling: #3417

Server exported STORE_REST but started immediately. Wait for Store
/v1/health and exit 1 if the bounded wait expires.
@weicao
weicao requested review from a team and leon-ape as code owners August 19, 2026 02:25
@weicao
weicao merged commit bb20a02 into dev/hugegraph-release-1.0 Aug 19, 2026
7 checks passed
@weicao
weicao deleted the feat/hugegraph-server-wait-store-failclosed branch August 19, 2026 02:28
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (f79df45) to head (e005da9).
⚠️ Report is 1 commits behind head on dev/hugegraph-release-1.0.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           dev/hugegraph-release-1.0   #3418   +/-   ##
=========================================================
  Coverage                       0.00%   0.00%           
=========================================================
  Files                             69      69           
  Lines                           7275    7275           
=========================================================
  Misses                          7275    7275           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants