Expand the e2e test suite - #1541
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What?
Expand the a+ e2e test suite by adding 5 new tests and editing 3 existing tests to either increase testing scope or to make the test suite run better (I changed around some exercises the test use to make space for the new tests).
Why?
To increase e2e testing scope to better capture potential errors
How?
New tests:
test_batch_assess
test_deadline_deviations
test_edit_exercise
test_grading_modes (best/latest submission)
test_admin_permissions (in test_user_permissions.py)
I edited test_compare_submissions since it didn't pass before for me and test_text_exercise so that test_grading_modes can use exercise 5.1.4 in a+ manual.
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
I ran the e2e suite and it passed for me locally.
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!