Skip to content

Expand the e2e test suite - #1541

Merged
ihalaij1 merged 1 commit into
apluslms:masterfrom
reppuli92:master
Sep 15, 2026
Merged

ihalaij1 merged 1 commit into
apluslms:masterfrom
reppuli92:master

Conversation

@reppuli92

@reppuli92 reppuli92 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

What?

Expand the a+ e2e test suite by adding 5 new tests and editing 3 existing tests to either increase testing scope or to make the test suite run better (I changed around some exercises the test use to make space for the new tests).

Why?

To increase e2e testing scope to better capture potential errors

How?

New tests:
test_batch_assess
test_deadline_deviations
test_edit_exercise
test_grading_modes (best/latest submission)
test_admin_permissions (in test_user_permissions.py)

I edited test_compare_submissions since it didn't pass before for me and test_text_exercise so that test_grading_modes can use exercise 5.1.4 in a+ manual.

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Playwright tests.
  • Other test. (Add a description below)
  • Manual testing.

I ran the e2e suite and it passed for me locally.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@jkotimak jkotimak moved this from Todo to Under review in A+ sprints Sep 14, 2026
@ihalaij1
ihalaij1 self-requested a review September 15, 2026 06:39
@ihalaij1 ihalaij1 self-assigned this Sep 15, 2026

@ihalaij1 ihalaij1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ihalaij1
ihalaij1 merged commit 07c8b62 into apluslms:master Sep 15, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Under review to Done in A+ sprints Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants