Repository navigation
fix(ADFA-6269): publish addons against CodeOnTheGo's plugin-api-latest release - #112
Merged
Merged
Conversation
…t release Publish addons built every addon against the jars committed in libs/, which only change when someone runs Update libs. Vector-Search adopted EmbeddingBackend (#104) after the last refresh, so the release path failed with an unresolved reference while PR CI and local builds looked fine. The workflow now downloads plugin-api.jar and gradle-plugin.jar from the plugin-api-latest release, checks them against its checksums.txt, and takes PLUGIN_LIBS_REVISION from the release's target commit instead of parsing libs/ commit subjects. It fails if the release is republished mid-download, since CoGo recreates that tag on every run.
jatezzz
approved these changes
Sep 28, 2026
…a heap setting Publish addons failed Vector-Search in lintVitalAnalyzeRelease with the daemon out of Metaspace at Gradle's defaults (512 MiB heap, 384 MiB metaspace). Seven addons set no org.gradle.jvmargs at all; they now use -Xmx2048m like most of the repo, which also lifts the metaspace cap.
hal-eisen-adfa
added a commit
that referenced
this pull request
Oct 2, 2026
…/README.md ADFA-6269 (#112) edited two CLAUDE.md paragraphs that this branch had moved to plugins/README.md: Publish addons now builds against CodeOnTheGo's plugin-api-latest release rather than the committed libs/, and libs_revision comes from that release's target commit rather than a commit subject. CLAUDE.md keeps this branch's version. The new wording goes to where the paragraphs now live, so it is not lost in the move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish addons built every addon against the jars committed in libs/, which only change when someone runs Update libs. Vector-Search adopted EmbeddingBackend (#104) after the last refresh, so the release path failed with an unresolved reference while PR CI and local builds looked fine.
The workflow now downloads plugin-api.jar and gradle-plugin.jar from the plugin-api-latest release, checks them against its checksums.txt, and takes PLUGIN_LIBS_REVISION from the release's target commit instead of parsing libs/ commit subjects. It fails if the release is republished mid-download, since CoGo recreates that tag on every run.