-
Notifications
You must be signed in to change notification settings - Fork 18
fix: handle generated SDK input validation #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HarshMN2345
wants to merge
5
commits into
main
Choose a base branch
from
codex/mcp-query-strings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eafe04e
fix: validate query string lists before SDK execution
HarshMN2345 15cd7b8
test: cover query validation through public MCP calls
HarshMN2345 c6a7a32
Merge main into codex/mcp-query-strings
HarshMN2345 29eab19
test: cover upstream SDK query error handling
HarshMN2345 eabc50d
fix: classify generated SDK input validation errors
HarshMN2345 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new public-handler regression depends on SDK-side validation that is absent from the currently locked
appwrite-console==0.6.0, so the normal test suite fails for every malformed-input case. Until the dependency requirement and lockfile select a published release containing these guards, removing the MCP guard leaves current installations exposed to the original serialization failure and this PR cannot pass CI.Prompt To Fix With AI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed; this is the explicit merge blocker recorded at the top of the PR description, and the PR remains draft. The required sequence is to land the schema-driven generator guards in appwrite/sdk-generator#1899, publish the generated SDK from appwrite/sdk-for-console-python#10, then update MCP's requirement and lockfile to that published version. The actual regenerated SDK passes all 263 MCP unit tests through a temporary source overlay, while locked 0.6.0 reproduces exactly this regression in local and GitHub CI. This thread remains unresolved until the real dependency update makes the normal suite pass; the regression will not be weakened or skipped.