Skip to content

Preserve integer precision in ordering comparisons - #26

Closed
qoke wants to merge 2 commits into
ardanlabs:mainfrom
iqhive:jinjafix-integer-ordering
Closed

qoke wants to merge 2 commits into
ardanlabs:mainfrom
iqhive:jinjafix-integer-ordering

Conversation

@qoke

@qoke qoke commented Oct 22, 2026

Copy link
Copy Markdown

Closes #17.

Ordering comparisons could lose precision by converting large integers to floating point. This made 9007199254740992 < 9007199254740993 return False, despite both values being within the supported integer range.

Integer operands are now compared without conversion. Mixed integer–float comparisons handle floating-point bounds and fractional components without first rounding the integer to a float.

Both regression cases, covering integer–integer and integer–float ordering, now match the Python reference results. The original failing Go results are included for comparison.

go test -count=1 ./... passes.

@ardan-bkennedy

Copy link
Copy Markdown
Contributor

Thank you, @qoke, for reporting these issues and for providing proposed fixes. We reviewed all nine reports and used your suggestions where they made sense in the codebase. All nine issues have now been resolved in #34, each with corresponding regression tests, and the fixes are published in v1.11.0.

The issue addressed by this PR (#17) is covered by that release, so we are closing this PR in favor of the consolidated fix.

For future reports, please start with issues only so we can discuss the approach before opening pull requests. Thanks again for helping improve the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve integer precision in ordering comparisons

2 participants