Skip to content

Fix selection-filter panics when no test is supplied - #32

Closed
qoke wants to merge 2 commits into
ardanlabs:mainfrom
iqhive:jinjafix-selection-default-tests
Closed

qoke wants to merge 2 commits into
ardanlabs:mainfrom
iqhive:jinjafix-selection-default-tests

Conversation

@qoke

@qoke qoke commented Oct 22, 2026

Copy link
Copy Markdown

Closes #22.

Calling select, reject, selectattr, or rejectattr without an explicit test could panic while extracting optional test arguments. These are supported calls that should use truthiness.

The filters now check the argument count before slicing and use an empty argument list when no additional test arguments are present. Explicit tests and their arguments continue to pass through unchanged.

[0, 1, 2] | select | list now returns [1, 2], and the corresponding reject call returns [0].

The four regression cases capture the original Go failures and verify that every default-test filter form matches Python’s output.

@ardan-bkennedy

Copy link
Copy Markdown
Contributor

Thank you, @qoke, for reporting these issues and for providing proposed fixes. We reviewed all nine reports and used your suggestions where they made sense in the codebase. All nine issues have now been resolved in #34, each with corresponding regression tests, and the fixes are published in v1.11.0.

The issue addressed by this PR (#22) is covered by that release, so we are closing this PR in favor of the consolidated fix.

For future reports, please start with issues only so we can discuss the approach before opening pull requests. Thanks again for helping improve the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix selection-filter panics when no test is supplied

2 participants