Add negative examples that should retain ordinary prose #180

PRI-05 · Privacy filtering

Difficulty: beginner · Status: ready

This is a focused contribution against current main. No unmerged feature PR is required.

Why this is useful

Over-redaction can hide useful scam context

Start here

Source audit: 9d8ac3e01df1. Read these files on current main too, because paths may change after the audit:

• app/services/filter.py
• app/services/ai.py
• docs/src/content/docs/guides/privacy.md

Scope and intended output

Add the focused test file tests/roadmap/privacy/test_safe_prose.py. Change runtime code only if the acceptance criteria explicitly request a behavior fix; otherwise report newly discovered behavior separately.

Acceptance criteria

• Use benign synthetic sentences without identifiers
• Assert exact preservation
• Keep disputes about numeric sequences as separate design cases

Verification

uv run pytest tests/roadmap/privacy/test_safe_prose.py -q
uv run pylint app tests

Create the named focused test file before running its command. Tests must be deterministic, mock external services, and avoid paid calls. Run bash scripts/check.sh before submitting a Python change.

Dependencies

None. Keep the PR based on current upstream main.

Out of scope

• Unrelated refactors, broad formatting, endpoint renames, or extra dependencies without agreement.
• Live cloud provisioning, paid model calls, real private messages, or credentials in fixtures/logs.
• Implementing neighboring roadmap issues in the same PR.

Getting help and submitting

Comment with your intended approach and ask when expected behavior is unclear. Check for an existing PR before starting; there is no deadline for a volunteer contribution. A useful reproduction or partial finding is welcome.

Use the issue's criteria as the review checklist. Include the commands actually run and any limitations. Link the issue; use Fixes only when its entire agreed scope is complete. If CONTRIBUTING.md is not yet on main, the contributor-roadmap PR provides the onboarding guide.