Keep phpstan/phpstan-phpunit in sync with the forced phpunit/phpunit upgrade on lowest-deps CI - #8
Merged
Conversation
…upgrade on lowest-deps CI Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lowest-deps CI job force-upgradesphpunit/phpunit(and a few other tools) to their latest version aftercomposer-installresolves lowest bounds, but leftphpstan/phpstan-phpunitbehind at whatever old version it resolved to.->expects()->method()mock chain, the stalephpstan-phpunitextension references a PHPUnit mock class that no longer exists in the force-upgraded PHPUnit, andvendor/bin/phpstanfails with aclass.notFounderror on thelowestmatrix legs.assoconnect/php-quality-configdependency that pulls inphpstan/phpstan-phpunit.Test plan
composer update --prefer-lowest --prefer-stablethen the tool-upgrade step reproducesphpstan/phpstan-phpunitstaying at 2.0.0 whilephpunit/phpunitjumps to 13.x, triggering theclass.notFounderror on a test using->expects()->method().phpstan/phpstan-phpunitadded to the upgrade step,phpstan/phpstan-phpunitupgrades to 2.0.18 alongsidephpunit/phpunitand the error disappears.🤖 Generated with Claude Code