Memoize the hydrated PublicSuffixList in-process - #93
Merged
Conversation
The PSR-16 cache avoids re-downloading the Public Suffix List, but every PublicSuffixListClient::get() call still unserializes the full Rules object from the cache backend. Processes validating many email addresses pay that cost on every validation. Pdp\Storage\PublicSuffixListClient is now aliased to an in-memory memoizing decorator around RulesStorage, so the list is hydrated once per process. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemoizingPublicSuffixListClient, an in-memory decorator around the PSR-16-cachedRulesStorage, and points thePdp\Storage\PublicSuffixListClientalias at it.get()call still reads the cache backend and unserializes the fullPdp\Rulesobject. Processes validating many email addresses (imports, campaigns) pay that cost on every validation. With this decorator the list is hydrated once per process and reused.PublicSuffixListCacheWarmerkeeps injectingRulesStoragedirectly, so cache warm-up behavior is unchanged.Pdp\Storage\PublicSuffixListClientcan remove it after upgrading.Test plan
🤖 Generated with Claude Code