Repository navigation
fix(app): pass AppImage catalog validation - #296
Merged
Merged
Conversation
av
marked this pull request as ready for review
October 24, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harbor’s AppImage had a broken
.DirIconpointing at GitHub’s build directory. Update Tauri CLI and both lockfiles to 2.11.4 (upstream fix). The full test exposed two more blockers: a launcher ordinary users cannot execute, fixed by a Linux pre-bundle hook, and a blank window from circular React/Markdown loading, fixed by keeping shared JavaScript helpers with React.Add
# Harbor: the catalog’s README heuristic was reading a shell comment. Add PR-only build/catalog validation to the release workflow; publishing remains excluded on PRs. No new project dependencies or modified catalog tests.Local Ubuntu 22.04 VM, unchanged catalog worker from the failed run:
Desktop, icon, launch, screenshot and catalog generation pass. Remaining warnings: no AppStream metadata, bundled libwayland-client, no update information. CI passed; full logs and screenshot are attached to that run. Publishing jobs were skipped.
After Ivan approves publication: merge; choose the next version in
.scripts/seed.ts, runharbor dev seedand(cd app/src-tauri && cargo update --workspace), then commit/push. Wait for Harbor App Release, publish its completed draft with the rebuilt amd64 AppImage, and verify the published asset with the catalog test. Post exactly this on the catalog PR: