Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
|
This seems like AI slop closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Profile snapshots are stored as JSON in the App Group so widgets and DeviceActivity extensions can resolve profile settings without accessing SwiftData.
ProfileSnapshotgained three non-optional properties after snapshot persistence shipped. Swift's synthesizedDecodabledoes not use property initializers when a key is absent, so snapshots written by older releases fail withkeyNotFound.The current collection decoder converts any entry failure into an empty dictionary. Extensions can then fail to resolve every profile, and a later read-modify-write can replace the derived snapshot map with only the newly written entry. Canonical SwiftData profiles are not deleted.
Compatibility defaults
Missing fields use the same defaults as
BlockedProfiles, preserving the behavior users had before each setting was introduced:breakTimeInMinutes:15enableSafariBlocking:trueenableBlockAppInstallation:falseExplicit values in current snapshots remain unchanged.
Tests
Scope
This changes only decoding of the derived App Group snapshot data. It does not modify the SwiftData schema or canonical profile records.
Validation
make lint(completed; changed files have no format findings)make buildmake test(53 tests passed)make mac-test(11 tests passed)git diff --check