Skip to content

#241 First pass at CloudFormation parameter validation - #242

Open
corey-cole wants to merge 3 commits into
aws-cloudformation:mainfrom
corey-cole:main
Open

#241 First pass at CloudFormation parameter validation#242
corey-cole wants to merge 3 commits into
aws-cloudformation:mainfrom
corey-cole:main

Conversation

@corey-cole

Copy link
Copy Markdown

Issue #, if available: 241

Description of changes:
Rules for checking CloudFormation parameter overrides. See AWS CLIv2 docs for more details.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@satyakigh satyakigh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ARN regex rejects valid partitions and services containing -: \w+ does not match aws-cn, aws-us-gov, or services such as execute-api. The selector still includes these values because /^arn:aws/ matches their prefix, so they are reported malformed. I reproduced both arn:aws-cn:s3:... and arn:aws:execute-api:... exiting 19; using [\w-]+ for partition and service makes both pass. Please update the regex and add representative tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants