chore(maintenance): scope test:unit to tests/unit and align cached-node-modules action pins - #5649
Conversation
…on pins - Scopes vitest to tests/unit in 6 packages (commons, batch, jmespath, kafka, testing, validation) to prevent e2e tests from running in local unit test runs. Fixes aws-powertools#5643. - Updates all cached-node-modules action uses to v1.5.0 (3b5b8e2e) with version comment, replacing the older January 2025 pin. Fixes aws-powertools#5642.
|
No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template at |
|
Coudl you use the |
|
Thank you for taking the time to contribute! We've decided to handle this one as maintainers since it touches conventions we're standardizing across the repo, and it's now addressed in #5653. The GitHub Actions pin changes bundled here are out of scope for #5643 — if there's a concrete problem behind them, please open a separate issue so we can look at it on its own merits. Closing this in favor of that PR — we'd be happy to see you pick up another issue. |
Summary
Two maintenance fixes:
Fix 1: Scope test:unit to tests/unit (#5643)
Six packages (commons, batch, jmespath, kafka, testing, validation) defined
test:unitas barevitest --run. Without an explicitincludepath,the default glob matches
tests/e2e/*.test.tsas well, sonpm run test:unitin the batch package runs the SQS e2e suite which requires AWS credentials.
Fix: Update
test:unittovitest --run tests/unitin all six affectedpackages. Also normalises
test:e2eandtest:unit:typesplaceholder strings.Fix 2: Align cached-node-modules action pins (#5642)
The
cached-node-modulescomposite action is pinned at two different commitsacross workflows: the older January 2025 pin (
29979bc5) has no versioncomment, so Dependabot never proposes bumping it. The newer August 2025 pin
(
3b5b8e2e,v1.5.0) carries the comment.Fix: Update all 13 uses of the old pin to
v1.5.0with a# v1.5.0comment, so all workflows use the same version and Dependabot can track them.
Fixes #5643, #5642