Skip to content

[Test] test_expedited_requeue: fix the ICE emulation. - #7629

Merged
gmarciani merged 2 commits into
aws:developfrom
gmarciani:wip/mgiacomo/3170/test-expedite-0916-1
Sep 17, 2026
Merged

gmarciani merged 2 commits into
aws:developfrom
gmarciani:wip/mgiacomo/3170/test-expedite-0916-1

Conversation

@gmarciani

@gmarciani gmarciani commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes

In test_expedited_requeue: fix the ICE emulation.

the test started failing after aws/aws-parallelcluster-node#734 That PR fixed the way we report the EC2 CreateFleet failures by surfacing the actual EC2 error. This fix broke the test logic we used to emulate ICEs. We emulate ICEs by requesting an invalid instance types, the old logic mapped this failure into ICE. The fixed logic instead surfaced the InvalidParameterValue.

We applied in this test the same ICE emulation mechanism used in the test test_fast_capacity_failover, which was fixed for the same reason by #7621.

Tests

SUCCESS

test-suites:
  schedulers:
    test_slurm.py::test_expedited_requeue:
      dimensions:
        - regions: ["us-east-1"]
          instances: ["c5.xlarge"]
          oss: ["rhel8"]
          schedulers: ["slurm"]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x Test labels Sep 16, 2026
@gmarciani
gmarciani force-pushed the wip/mgiacomo/3170/test-expedite-0916-1 branch from d1ac048 to 6349571 Compare September 16, 2026 21:54
@gmarciani
gmarciani marked this pull request as ready for review September 16, 2026 22:02
@gmarciani
gmarciani requested review from a team as code owners September 16, 2026 22:02
@gmarciani
gmarciani enabled auto-merge (rebase) September 17, 2026 13:55
@gmarciani
gmarciani merged commit 6a7b001 into aws:develop Sep 17, 2026
20 checks passed
@gmarciani
gmarciani deleted the wip/mgiacomo/3170/test-expedite-0916-1 branch September 17, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants