fix: add missing AWS SDK dependencies to TypeScript agent package.json - #2010
Open
jyotsnamas wants to merge 1 commit into
Open
fix: add missing AWS SDK dependencies to TypeScript agent package.json#2010jyotsnamas wants to merge 1 commit into
jyotsnamas wants to merge 1 commit into
Conversation
@strands-agents/sdk requires @aws-sdk/client-bedrock-runtime and @aws-sdk/client-s3 as peer dependencies, but they weren't listed in package.json. This causes `npm install && npm run build` to fail because esbuild cannot resolve the imports during bundling. Without this fix, the deployed runtime also crashes at startup with "Cannot find module '@aws-sdk/client-bedrock-runtime'" if the bundle is built with --external:@aws-sdk/*. Verified by deploying to AgentCore Runtime (NODE_22) in us-west-2: - Without fix: build fails or runtime crashes with ModuleNotFoundError - With fix: agent responds correctly to calculator prompts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@aws-sdk/client-bedrock-runtimeand@aws-sdk/client-s3topackage.jsondependencies@strands-agents/sdkrequires these as peer dependencies but they weren't listed, sonpm install && npm run buildfails out of the boxRoot cause
esbuild bundles all imports (no
--externalflag in the build script). Without these packages installed, the build fails:If you work around the build by adding
--external:@aws-sdk/*, the deployed runtime crashes at startup:Verification
Deployed to AgentCore Runtime (NODE_22) in us-west-2:
Cannot find modulenpm install && npm run buildsucceeds, agent responds correctlyTest plan
npm install && npm run buildsucceeds without manual intervention🤖 Generated with Claude Code