fix(DB): Pay Freya's Elders their 3.1 emblems - #496
Conversation
Killed before Freya is engaged, each Elder owes the emblem her chest then no longer hands out: Valor in 10-man, Conquest in 25-man. Core gives all six entries one shared Emblem of Triumph, which this bracket cannot simply convert. The 25-man Ironbranch and Stonebark have no loot id of their own, and the 25-man Brightleaf points at the 10-man table, so one table would have to hold both emblems. Split the loot ids and rebuild the rows instead, keeping Brightleaf's Book of Glyph Mastery on both sizes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe SQL update rebuilds loot for Freya’s Elders. It assigns 25-man loot IDs, removes existing emblem and book rows, and inserts separate 10-man and 25-man emblem drops plus Brightleaf Book of Glyph Mastery drops. ChangesFreya Elder Loot
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The migration assigns the correct emblems and Brightleaf book drops for both raid modes without introducing a known merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Freya's Elders drop no emblem when killed before the encounter starts.
Freya's Gift pays one emblem plus one per Elder left alive to empower her, so an Elder killed early owes exactly the emblem the chest then no longer hands out. At 3.1 that is Emblem of Valor in 10-man and Emblem of Conquest in 25-man, matching the rest of this bracket.
Core only gives the six entries one shared Emblem of Triumph (azerothcore/azerothcore-wotlk#27634), so unlike the rest of this file the rows cannot simply be converted:
So the loot ids are split and the rows rebuilt. Splitting 33391 off would have dropped the Book of Glyph Mastery it was inheriting from 32915, so that row is re-added on the 25-man side.
Applying the file twice produces identical rows, so it stays replay-safe when the DB updater re-runs it.
ulduar_hard_mode_emblems.cppneeds no change: it only swaps Valor for Conquest while a hard-mode loot mode is set, and an Elder killed before the pull loots on the default mode.Tests Performed
Applied the full bracket file against a live world database. All three Elders yield one Emblem of Valor at 10-man and one Emblem of Conquest at 25-man, and 33391 keeps its Book of Glyph Mastery.
Known Issues
The 25-man Freya's Gift emblem counts were already inconsistent before this change and are left alone here. Counting the reference 34349 rolls alongside the direct rows, the 25-man chest pays 1 / 6 / 5 / 3 Conquest as the Elder count rises, where the 10-man ladder this bracket normalises is a clean 1 / 2 / 3 / 4 Valor plus the hard-mode Conquest.
🤖 Generated with Claude Code
Summary by CodeRabbit