fix(DB): Pay one Emblem of Conquest from Kologarn's 25-man cache - #504
Conversation
The 80_2 conversion kept the stock 1-2 count, so the cache rolled one or two emblems per kill. Every other normal-mode Ulduar cache pays one.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe SQL update sets the 25-man Kologarn cache Conquest emblem drop count to exactly one. ChangesKologarn Emblem Drop
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The intended drop-count correction is isolated and ready to merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The 80_2 Ulduar emblem file converts the 25-man Cache of Living Stone (loot 26929) to Emblem of Conquest but keeps the stock MinCount 1 / MaxCount 2, so each Kologarn 25 kill paid the raid one or two emblems at random. Kologarn has no hard mode, and every other normal-mode Ulduar cache pays one, so the row is now pinned to 1/1.
The stock count is also wrong in core, fixed by azerothcore/azerothcore-wotlk#27887. This file sets the count itself so it holds whether or not that has been merged.
Reported in azerothcore/azerothcore-wotlk#27886.
Summary by CodeRabbit