Skip to content

fix(DB): Pay one Emblem of Conquest from Kologarn's 25-man cache - #504

Merged
Nyeriah merged 1 commit into
mainfrom
fix-kologarn-25-emblem-count
Oct 1, 2026
Merged

Nyeriah merged 1 commit into
mainfrom
fix-kologarn-25-emblem-count

Conversation

@Nyeriah

@Nyeriah Nyeriah commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

The 80_2 Ulduar emblem file converts the 25-man Cache of Living Stone (loot 26929) to Emblem of Conquest but keeps the stock MinCount 1 / MaxCount 2, so each Kologarn 25 kill paid the raid one or two emblems at random. Kologarn has no hard mode, and every other normal-mode Ulduar cache pays one, so the row is now pinned to 1/1.

The stock count is also wrong in core, fixed by azerothcore/azerothcore-wotlk#27887. This file sets the count itself so it holds whether or not that has been merged.

Reported in azerothcore/azerothcore-wotlk#27886.

Summary by CodeRabbit

  • Bug Fixes
    • The 25-player Kologarn cache now consistently drops exactly one Conquest emblem.

The 80_2 conversion kept the stock 1-2 count, so the cache rolled one or
two emblems per kill. Every other normal-mode Ulduar cache pays one.
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b24af666-3140-47f8-a945-daac8de2edff

📥 Commits

Reviewing files that changed from the base of the PR and between 0ef5f13 and 8b6538d.

📒 Files selected for processing (1)
  • src/Bracket_80_2/sql/world/progression_80_2_ulduar_emblems.sql

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The SQL update sets the 25-man Kologarn cache Conquest emblem drop count to exactly one.

Changes

Kologarn Emblem Drop

Layer / File(s) Summary
Set Kologarn drop count
src/Bracket_80_2/sql/world/progression_80_2_ulduar_emblems.sql
For entry 26929, the Conquest row now has MinCount and MaxCount set to 1.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 8b653

The intended drop-count correction is isolated and ready to merge.

Architecture Summary

Architecture risk: 🔵 Low · up to 8b653

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/Bracket_80_2/sql/world/progression_80_2_ulduar_emblems.sql: Adds a correction for the 25-man Kologarn cache: when entry 26929 has the Conquest item, its minimum and maximum drop counts are both set to 1.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: making Kologarn's 25-man cache pay one Emblem of Conquest.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Nyeriah
Nyeriah merged commit a4e785a into main Oct 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant