Skip to content

Document AzerothCore script hook categories - #1278

Merged
Kitzunu merged 43 commits into
masterfrom
copilot/create-pr-document-script-hooks
Sep 23, 2026
Merged

Kitzunu merged 43 commits into
masterfrom
copilot/create-pr-document-script-hooks

Conversation

Copilot AI commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

The C++ hooks page documented how to create hooks, but not how to navigate the hook surface already exposed by AzerothCore. This update adds a compact reference for the main ScriptMgr hook groups and mirrors the same guidance in the Spanish page.

  • Hook reference

    • add a categorized index of script hook families on docs/hooks-script.md
    • group hooks by responsibility: lifecycle/server, entities/maps, and systems/game rules
    • call out representative entry points so readers can jump directly to the right ScriptMgr.h section
  • Database hook coverage

    • keep the existing DatabaseScript section visible as part of the hook reference flow
    • retain the key module database lifecycle callbacks in the same page context
  • Spanish parity

    • mirror the new reference content in docs/es/hooks-script.md
    • localize labels and wording for consistent navigation in the Spanish docs set
  • Example

    // Pick the hook family that matches the subsystem you want to extend.
    sScriptMgr->OnBeforeConfigLoad(reload);   // WorldScript
    sScriptMgr->OnPlayerLogin(player);        // PlayerScript
    sScriptMgr->OnGameEventStart(eventId);    // GameEventScript

Copilot AI and others added 8 commits September 20, 2026 10:24
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6c0c8bec-5930-45ec-875d-da5bf2dddb93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI and others added 14 commits September 20, 2026 10:33
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Copilot AI and others added 19 commits September 20, 2026 10:44
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
- PlayerScript header claimed 190 signatures but the block only lists 189
- Restore the actual ScriptMgr.h spellings/signature for OnGuildMemberWitdrawMoney,
  OnHeal's reciever parameter, and the missing const on
  OnPlayerGetMaxPersonalArenaRatingRequirement so copy-pasted code matches the
  real declarations
The new "Module and database hooks" bullets repeated the same five
hooks already covered by the existing "Database hooks" section
immediately below, in both the English and Spanish pages.
@Kitzunu
Kitzunu marked this pull request as ready for review September 23, 2026 17:51
@Kitzunu
Kitzunu merged commit 936a474 into master Sep 23, 2026
2 checks passed
@Kitzunu
Kitzunu deleted the copilot/create-pr-document-script-hooks branch September 23, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants