refactor: add consumer-neutral CLI profiles - #17
Merged
Conversation
codeforester
marked this pull request as ready for review
July 30, 2026 21:17
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
base_cli is intended to be a standalone CLI lifecycle library, but App directly encoded Base manifest, config, cache, history, and delegation conventions.
Impact
Standalone consumers can opt into CliProfile.generic() with no implicit manifest, product-owned config, or history behavior. Existing App() callers retain historical Base behavior through CliProfile.legacy_base() while the Base repository migrates to an explicit adapter.
Root cause
Consumer-specific policy lived inside the generic application lifecycle instead of being injected at the boundary.
Checks
Fixes #16
This is the first compatibility-preserving migration slice. Follow-up work will move the legacy Base adapter and remaining Base-shaped context/config/history types into the Base consumer. The package rename is intentionally out of scope.