Skip to content

Fix base-cli review findings - #8

Merged
codeforester merged 1 commit into
mainfrom
bug/7-20260729-base-cli-review-fixes
Jul 30, 2026
Merged

Fix base-cli review findings#8
codeforester merged 1 commit into
mainfrom
bug/7-20260729-base-cli-review-fixes

Conversation

@codeforester

Copy link
Copy Markdown
Contributor

Summary

Fixes #7.

This PR addresses the concrete correctness, security, portability, performance, documentation, and adoption findings from the base-cli review.

What changed

  • Bound checkout version discovery so unrelated ancestor VERSION files cannot override installed metadata.
  • Validate command return values and report invalid non-integer results clearly.
  • Enforce owner-only runtime directories (0700) and private JSON files (0600).
  • Make base_cli.testing.invoke(cwd=...) expose the fixture directory to real filesystem operations and restore the caller's cwd.
  • Centralize YAML dependency loading and private JSON writes.
  • Add a Windows history-lock fallback using a private sidecar lock file.
  • Add an indexed log-retention path to avoid rediscovering the full run tree on every invocation.
  • Enable color automatically on interactive terminals while honoring NO_COLOR and explicit opt-out.
  • Add downstream command-protocol schema registration with validation.
  • Repair README links, add the missing local-configuration and cache-layout docs, and document Click shell completion.

Compatibility note

The existing IDE schema and Base command-display compatibility remain in place; removing those would be a separate breaking extraction decision.

Validation

  • uv run --extra dev pytest -q
  • ./tests/validate.sh
  • python3 -m compileall -q lib/python tests
  • uv run --extra dev python -m build
  • git diff --check

@codeforester
codeforester marked this pull request as ready for review July 30, 2026 14:38
@codeforester
codeforester merged commit c398901 into main Jul 30, 2026
11 of 12 checks passed
@codeforester
codeforester deleted the bug/7-20260729-base-cli-review-fixes branch July 30, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address Claude review findings in base-cli

1 participant