refactor: own Base IDE and history policies in Base - #1822
Closed
codeforester wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 31, 2026
Collaborator
Author
|
Superseded by #1824, which uses the issue-backed branch enhancement/1823-20260730-base-consumer-policy and updates the merged base-cli CI pin. |
codeforester
added a commit
that referenced
this pull request
Jul 31, 2026
Fixes #1823 and supersedes #1822.\n\nBase CI was checking out base-cli commit 59471fa, which predates merged base-cli PR #18. The consumer-policy code therefore failed during collection with CliProfile.__init__() got an unexpected keyword argument 'history_display_command' and related pylint errors.\n\nThis PR pins all Base source-checkout and pylint workflows to merged base-cli commit beb9995, uses an issue-backed branch so Issue Branch Policy can validate it, and preserves the Base IDE/history consumer extraction from #1822.\n\nValidation: full local Base suite — 932 passed; git diff --check passed. Package renaming remains out of scope.:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports basefoundry/base-cli#9 and follows basefoundry/base-cli#18.\n\n- moves VS Code/Cursor definitions and project auto-setting policy into base_setup.ide_schema\n- moves Base command history aliases into base_history.display\n- injects Base's history display policy through base_cli_profile\n- keeps Base config validation strict by supplying its supported IDE set\n- updates Base imports, compatibility coverage, and context documentation\n\nThis PR should merge after base-cli#18 is available to the Base provider. Package renaming remains out of scope.\n\nValidation: full pytest — 932 passed.: