Skip to content

fix: unfold session-close changelog entry from released v0.126.1 - #145

Merged
bborbe merged 3 commits into
masterfrom
fix/changelog-unfold-session-close
Sep 6, 2026
Merged

fix: unfold session-close changelog entry from released v0.126.1#145
bborbe merged 3 commits into
masterfrom
fix/changelog-unfold-session-close

Conversation

@bborbe

@bborbe bborbe commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Problem

The v0.126.1 tag was cut at 18:16:57Z. PR #143 merged at 18:29:09Z — twelve minutes later. Its CHANGELOG bullet sat under ## Unreleased, which the release cut had already renamed to ## v0.126.1, so the merge folded the entry into an already-released section.

Net effect: the v0.126.1 tag claims a session-close change it does not contain.

$ gh api "repos/bborbe/vault-cli/contents/commands/session-close.md?ref=v0.126.1" | ... | grep -c 'leave it open'
0

Fix

Master is fixed; the tag is left untouched. The bullet moves from ## v0.126.1 back to ## Unreleased, where it will be picked up by the next release cut.

Verification

The released section is now byte-identical to the tag:

$ diff <(git show v0.126.1:CHANGELOG.md | sed -n '/^## v0.126.1/,/^## v0.126.0/p') \
       <(sed -n '/^## v0.126.1/,/^## v0.126.0/p' CHANGELOG.md)
BYTE-IDENTICAL to tag v0.126.1 ✅

CHANGELOG-only change; no code touched.

… Unreleased

The v0.126.1 tag was cut at 18:16:57Z; PR #143 merged at 18:29:09Z. Its
CHANGELOG bullet was written under '## Unreleased', which the release cut had
already renamed, so the merge folded the entry into the released section. The
tag therefore claimed a session-close change it does not contain.

Master is fixed, the tag is left alone: the bullet moves to '## Unreleased' and
the v0.126.1 section is now byte-identical to the tag.

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is a single changelog-only change — one bullet moved from v0.126.1 back into Unreleased. No code changes, no build artifacts, no test files.

Review finding: The change is correct and self-explanatory. No issues.


Verdict: approve

{
  "verdict": "approve",
  "summary": "Changelog-only change: one fix entry ('session-close offers leave it open') moved from released v0.126.1 back into Unreleased. No code, no version bump needed. Clean.",
  "comments": [],
  "concerns_addressed": []
}

Merging origin/master applied cleanly and produced the wrong result: the
v0.126.2 release cut renamed '## Unreleased', so git textually matched the
bullet's insertion point against the renamed section and the entry landed
inside the freshly-released v0.126.2.

Restored to a fresh '## Unreleased' above v0.126.2. Both released sections are
now byte-identical to their tags.
@ben-s-pull-request-reviewer
ben-s-pull-request-reviewer Bot dismissed their stale review September 6, 2026 19:43

superseded by new automated review

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is a pure CHANGELOG.md edit — one entry moved from v0.126.1 to ## Unreleased. Let me verify the change is structurally correct per the changelog guide:

Structure check:

  • ## Unreleased placed immediately after the preamble ✅
  • Entry uses fix: conventional prefix ✅
  • Entry describes the specific change with context ✅
  • No version strings modified (this is an autoRelease: true repo — version strings stay at last released until post-merge) ✅
  • No preamble disruption ✅

The change correctly unfolds a changelog entry that was in the wrong version section — moving it from v0.126.1 to ## Unreleased where it belongs until the fix ships.

{
  "verdict": "approve",
  "summary": "Pure CHANGELOG.md reordering: one fix entry moved from v0.126.1 to ## Unreleased. Structure is correct per changelog-guide.md — valid prefix, proper section placement, no preamble disruption, no version strings touched.",
  "comments": [],
  "concerns_addressed": []
}

@bborbe
bborbe merged commit 484fb03 into master Sep 6, 2026
2 checks passed
@bborbe
bborbe deleted the fix/changelog-unfold-session-close branch September 6, 2026 19:44

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is clean and minimal — only CHANGELOG.md changed, 4 lines added, 1 deleted. The change correctly moves the "session-close offers 'leave it open'" fix entry from the released ## v0.126.1 section back to ## Unreleased, which is the correct procedure when an entry was accidentally included in a published release.

No code files changed. No automated checks are applicable to a pure changelog edit.

{
  "verdict": "approve",
  "summary": "Pure changelog management PR that correctly moves a mistakenly-released fix entry from v0.126.1 back to Unreleased. No code changes.",
  "comments": [],
  "concerns_addressed": []
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant