Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use beets'
zeroplugin to omit zero-valued track numbers when tags are written. After importing a singleton M4A with that setup,beet infoshows no track or disc metadata as expected, but Mp3tag and foobar2000 still show0for the track and disc numbers. The rawtrknanddiskatoms are both(0, 0).MP4 stores each number and total together as a pair, while MediaFile exposes them separately. When beets clears these fields, MediaFile deletes the number first, removing the shared pair. Deleting the total afterward recreates the missing pair as
(0, 0). MediaFile reads zero components as unset, so the problem is not visible in beets.I made a change so that deleting a total checks the pair's number first. If the number is missing or zero, MediaFile removes the pair; otherwise, it clears only the total and preserves the number. Regression tests check the raw Mutagen tags for both
trknanddisk.