Adding Algo Registration + Connecting to Vis - #70
Merged
Merged
Conversation
Algo registration
adjusting for image inputs as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the manually-maintained
ALGOSdict with decorator-based algorithm registration, wired through tovis.py.perception/tasks/registry.py(new):@register_perceiver(task=..., algo=...)decorator, plusget_perceiver,list_tasks,list_algos,discover_all(). Discovery walksperception.tasksand imports everything so decorators actually run — no shared file to hand-edit per new algorithm. Skips_archive/and swallows any import failure (missing torch/kornia/tqdm, etc.) with a warning, so one broken/optional module can't block discovering the rest.vis.py:--algorithm/ALGOSreplaced with--task/--algovia the registry. Unknown pairs now fail with a clear list of what's actually registered instead of a bareKeyError.Verified
All three tasks run clean through the real
vis.pyCLI (synthetic + real footage). Full suite passes (20/20, excluding_archive's unrelated pre-existing breakage). Lint checked against pre-edit baseline on every touched file — no new findings.Test plan
pytest --ignore=perception/tasks/_archivepython -m perception.vis.vis --task <gate|slalom|path_marker> --algo <...> --data <path>--task/--algoprints the available list