Scipy: fix some future tests - #7321
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #7321 +/- ##
==========================================
- Coverage 88.98% 88.98% -0.01%
==========================================
Files 336 337 +1
Lines 74567 74598 +31
==========================================
+ Hits 66353 66378 +25
- Misses 8214 8220 +6 🚀 New features to boost your workflow:
|
|
Should we try running tests with https://docs.scipy.org/doc/scipy/reference/sparse.migration_to_sparray.html#use-tests-to-find-and-spots? |
Probably... |
|
I tried the above tests. The only warnings I got were related to dimension reduction -- sum and mean over axes on sparse matrices produce 2d matrices, while on sparse arrays they will reduce dimension. Warnings came from our code and from sklear. In all cases, were happy with reduced arrays -- we actually make them dense and ravel them, as does sklearn. Our code seems ready for eventual migration to sparse arrays, when the time comes. |
Issue