Skip to content

[FIX] Concatenate: fix source ID as class problem - #7324

Closed
krystofair wants to merge 2 commits into
biolab:masterfrom
krystofair:krystofair/bugfix/concatenate-source-id-1
Closed

krystofair wants to merge 2 commits into
biolab:masterfrom
krystofair:krystofair/bugfix/concatenate-source-id-1

Conversation

@krystofair

@krystofair krystofair commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Using OWConcatenate with option add SourceID to classVar and ignore names from other table raise exception.

Issue

Fixes #7323

Description of changes

Make this IF branch working.

Includes
  • Code changes
  • Tests
  • Documentation

@krystofair krystofair changed the title Fix #7323 [wip] Fix #7323 Sep 18, 2026
@krystofair
krystofair force-pushed the krystofair/bugfix/concatenate-source-id-1 branch from 61afb42 to bffa812 Compare September 18, 2026 06:53
@krystofair krystofair changed the title [wip] Fix #7323 Fix #7323 Sep 18, 2026
@krystofair
krystofair force-pushed the krystofair/bugfix/concatenate-source-id-1 branch from bffa812 to 2a4aece Compare September 18, 2026 07:19
@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.98%. Comparing base (eea7a75) to head (265e98c).

❌ Your patch check has failed because the patch coverage (28.57%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7324   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files         337      337           
  Lines       74598    74603    +5     
=======================================
+ Hits        66378    66387    +9     
+ Misses       8220     8216    -4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janezd janezd added this to the 3.41 milestone Sep 25, 2026
@markotoplak markotoplak changed the title Fix #7323 [FIX] Concatenate: fix source ID as class problem Oct 8, 2026
@markotoplak
markotoplak force-pushed the krystofair/bugfix/concatenate-source-id-1 branch from a722adf to 265e98c Compare October 8, 2026 19:06
@markotoplak

Copy link
Copy Markdown
Member

Thanks for the PR. I close it in favor of #7340. The code in this PR is a substantial departure from the existing logic, and I'd rather stay closer to it. One of the differences that the "old" logic handles better are subclasses of Table (such as Corpus). Also, the proposed logic was a bit complex.

@markotoplak markotoplak closed this Oct 8, 2026
@krystofair
krystofair deleted the krystofair/bugfix/concatenate-source-id-1 branch October 8, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in OWConcatenate, when adding SourceID as class_var.

3 participants