Skip to content

[FIX] Rank: Fix loading workflow created with another language - #7332

Merged
VesnaT merged 1 commit into
biolab:masterfrom
janezd:rank-settings-as-ids
Oct 9, 2026
Merged

VesnaT merged 1 commit into
biolab:masterfrom
janezd:rank-settings-as-ids

Conversation

@janezd

@janezd janezd commented Sep 26, 2026

Copy link
Copy Markdown
Contributor
Issue

Fixes #7307

Description of changes

Add an integer id to ScoreMeta and store selected methods as ids, not string literals.

This does not affect connected scorers because they are not stored in settings. The use ScoreMeta, but id's are not used (we just use 100 + index, where index is an index of an input connection)

Includes
  • Code changes
  • Tests

@janezd
janezd force-pushed the rank-settings-as-ids branch from abe8351 to 7a040e7 Compare September 26, 2026 19:18
@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.97%. Comparing base (4d54417) to head (7a040e7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7332      +/-   ##
==========================================
- Coverage   88.99%   88.97%   -0.02%     
==========================================
  Files         337      337              
  Lines       74598    74600       +2     
==========================================
- Hits        66387    66375      -12     
- Misses       8211     8225      +14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janezd janezd added this to the 3.41 milestone Oct 8, 2026
@VesnaT
VesnaT merged commit 17edd62 into biolab:master Oct 9, 2026
47 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Rank widget uses method name as id as setting

2 participants