Performance: fix - throttle root persist writes and flush before suspend - #2315
Open
JohnathanWhite wants to merge 3 commits into
Open
Performance: fix - throttle root persist writes and flush before suspend#2315JohnathanWhite wants to merge 3 commits into
JohnathanWhite wants to merge 3 commits into
Conversation
redux-persist's throttle defaulted to 0, so the persist pipeline ran at maximum frequency; whenever the WALLET slice is dirty that pipeline re-runs pure-JS AES over six key fields per key and re-serializes merged BWC client objects. Throttling coalesces it. Because throttled writes can be starved indefinitely while several slices keep churning, persistence is now also flushed when the app backgrounds and after key create/import/delete. Also stops serializing the whole store twice at rehydrate for a log line.
Collaborator
|
follow up: JohnathanWhite#7 |
Performance: ref - remove persist throttle and inactive flush
JohnathanWhite
marked this pull request as ready for review
August 25, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redux-persist's throttle defaulted to 0, so the persist pipeline ran at maximum frequency; whenever the WALLET slice is dirty that pipeline re-runs pure-JS AES over six key fields per key and re-serializes merged BWC client objects. Throttling coalesces it. Because throttled writes can be starved indefinitely while several slices keep churning, persistence is now also flushed when the app backgrounds and after key create/import/delete. Also stops serializing the whole store twice at rehydrate for a log line.