KYC: Fix - Surface an error when identity verification cannot start - #2321
Open
cmgustavo wants to merge 1 commit into
Open
KYC: Fix - Surface an error when identity verification cannot start#2321cmgustavo wants to merge 1 commit into
cmgustavo wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds user feedback and loading state when identity verification cannot start.
Changes:
- Shows localized errors for authentication, token minting, and unavailable verification.
- Displays a spinner while requesting the SumSub token.
- Adds failure-path and spinner tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/store/sumsub/sumsub.effects.ts |
Adds error modals and token-loading state. |
src/store/sumsub/sumsub.effects.spec.ts |
Tests new feedback and spinner behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| dispatch( | ||
| showBottomNotificationModal( | ||
| CustomErrorMessage({ | ||
| errMsg: msg || t('The verification process encountered an error.'), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping "Verify My Identity" no longer does nothing. Every way the flow can fail before the SumSub SDK opens now shows the user a message, and the token mint gets a spinner.
The button was not unresponsive — it ran, failed, and said nothing.
startKycVerificationhad three silent exits, and the only path with user feedback was the one that fails after the SDK is already open:user/apiTokenLogActions.error+returnLogActions.info+returncatch(token mint threw)LogActions.erroronlyresult.status === 'Failed'From a restricted region the backend does not mint a token, so we hit one of the silent paths and returned. There was also no spinner during the mint, so even the happy path reads as a dead button on a slow connection.