Repository navigation
feat(slice): production results screen - #85
Open
bniladridas wants to merge 1 commit into
Open
bniladridas wants to merge 1 commit into
bniladridas wants to merge 1 commit into
Conversation
Stage 5: display-only results screen built from the manager finish snapshot at show time (order, laps, best times, YOU marker for the player slot). The mode shows it once when results finalize, which by manager design happens per finisher, so parked participants never block it. No restart flow, career, points, persistence, or audio work.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 5: production results screen, stacked on PR4. No restart flow, career, points, persistence, audio, pause, content, or cleanup.
Verify-first result: the finish data needed no work. FRaceResults exists with a finalized flag plus ordered entries, documented read-only for future UI. One real ambiguity was resolved before building: the header comment says the snapshot fills once when every participant has finished, but the code finalizes per finisher with parked pawns excluded by design. The code governs.
Adds a display-only results screen reading the snapshot at show time (place, participant, laps, best time, YOU marker for the player slot), shown once by the mode when HasResults turns true, with the race HUD hidden. No buttons; restart belongs to PR6.
Evidence: build Result Succeeded; regression checker exit 0 with 18 artifacts; full run to results (AI finished 2 laps, 1 finisher with the parked player correctly absent, row 1. P2 - 2 laps - best 16.77 s shown), zero errors. Displayed content matches the snapshot structurally with both logged. Rendered run reached results with a scene PNG; Slate text pixels remain under the known capture limitation.
Review question: does this establish finish to results without changing any other contract?