Repository navigation
MeshFactory::create read mesh from data directory - #3486
Merged
Merged
Conversation
Tries to read the mesh from data directory first, falling back to the previous behavior of reading relative to current directory. Uses C++20 <filesystem> to manipulate paths and test existence.
Member
|
Looks good! Please could you add something to the docs about this behaviour? |
If both data/file and ./file exist (and are different files), throw an exception rather than picking one. Document the new behavior and add unit tests.
bendudson
changed the title
Contributor
Author
|
Thanks @ZedThree ! Good point. I modified the behavior a bit and have added docs and unit tests. |
dschwoerer
previously approved these changes
Sep 4, 2026
dschwoerer
left a comment
dschwoerer
left a comment
Contributor
There was a problem hiding this comment.
Looks good, documentation could be improved.
Thanks @bendudson
Improved documentation. No code changes. [skip ci] Co-authored-by: David Bold <dave@ipp.mpg.de>
dschwoerer
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to read the specified mesh from data directory, falling back to the previous behavior of reading relative to current directory. If both
data_dir/fileand./fileexist then an exception will be thrown rather than picking one. If the mesh is given as an absolute path then it's unambiguous.This does change behavior but any ambiguous situations will result in an error rather than silently doing something strange.
Includes updates to docs and some unit tests.
Uses C++20 to manipulate paths and test existence.
Fixes issue #3300