Repository navigation
ADIOS2: Fix restart read/write - #3487
Merged
Merged
Conversation
Restarting from an ADIOS2 BOUT.restart.bp dataset and then writing
to it would produce an unusable restart dataset. Attempting to
restart a second time would either segfault or fail because variables
had the wrong shape.
Quoth GPT:
The main issue was that a restart read was preserving ADIOS’s
internal __xarray_dimensions__ metadata in the Options tree,
then writing it back out in a lossy form on the next restart
write. On the second restart that made ADIOS interpret generic
arrays as mesh fields with the wrong rank. I also tightened the
ADIOS stream lifecycle so finished streams retire their IO
objects cleanly instead of leaving stale cached state around.
Includes a new unit test that reproduced the original error and now
passes.
Force when modifying an Option.
Collaborator
|
Thanks for catching this @bendudson. I will review tomorrow. |
Steven-Roberts
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restarting from an ADIOS2
BOUT.restart.bpdataset and then writing to it would produce an unusable restart dataset. Attempting to restart a second time would either segfault or fail because variables had the wrong shape.Quoth GPT:
Includes a new unit test that reproduced the original error and now passes.