Skip to content

feat: add compose card field analytics - #1685

Open
saralvasquez wants to merge 1 commit into
card-fields-compose-featurefrom
compose-analytics
Open

feat: add compose card field analytics#1685
saralvasquez wants to merge 1 commit into
card-fields-compose-featurefrom
compose-analytics

Conversation

@saralvasquez

Copy link
Copy Markdown
Contributor

Summary of changes

  • adds analytics to CardFieldsState

AI Usage

Which AI Agent Was Used?

  • Copilot
  • Claude
  • Other (Type Name Here)

How was AI used?
Used claude to update unit tests

Estimated AI Code Contribution

  • less than 30%
  • 30 - 60%
  • 60 - 100%

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@saralvasquez
saralvasquez requested a review from a team as a code owner August 19, 2026 23:51

@agedd agedd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@noguier noguier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through complete flow and verified analytics are present! Looks great!

@buzzamus buzzamus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just left one tiny take it or leave it nit.

fun initialize(context: Context, authorization: String) {
cardClient = CardClient(context, authorization)
if (shouldSendPresentedEvent.value) {
shouldSendPresentedEvent.value = false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: just for readability should this be set after the event is sent? This is a very small thing admittedly, but I ended up reading through those 2 lines several times to understand then realized it made sense after reading the rest.

@saralvasquez
saralvasquez force-pushed the compose-analytics branch 2 times, most recently from 51ee071 to 287ffc2 Compare September 4, 2026 00:00
Base automatically changed from compose-pay-support to card-fields-compose-feature September 4, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants