feat: add compose card field analytics - #1685
Open
saralvasquez wants to merge 1 commit into
Open
Conversation
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 20, 2026 23:28
e99633e to
a49360d
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 24, 2026 16:58
a49360d to
517f89b
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 24, 2026 17:22
517f89b to
b45a56b
Compare
noguier
force-pushed
the
compose-analytics
branch
from
August 25, 2026 14:25
b45a56b to
e99633e
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 25, 2026 17:27
e99633e to
a49360d
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 25, 2026 17:29
a49360d to
7c5ff9c
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 25, 2026 21:50
7c5ff9c to
e01640b
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
2 times, most recently
from
August 25, 2026 22:29
6f2e04a to
22bf7d2
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 25, 2026 23:30
22bf7d2 to
03b7b21
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 26, 2026 16:29
03b7b21 to
7e2e081
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
2 times, most recently
from
August 26, 2026 18:57
028f95d to
a2915ab
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 26, 2026 21:28
a2915ab to
a389dba
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
August 26, 2026 22:01
a389dba to
c67df06
Compare
noguier
approved these changes
Aug 27, 2026
noguier
left a comment
Contributor
There was a problem hiding this comment.
I went through complete flow and verified analytics are present! Looks great!
buzzamus
approved these changes
Sep 1, 2026
buzzamus
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I just left one tiny take it or leave it nit.
| fun initialize(context: Context, authorization: String) { | ||
| cardClient = CardClient(context, authorization) | ||
| if (shouldSendPresentedEvent.value) { | ||
| shouldSendPresentedEvent.value = false |
Contributor
There was a problem hiding this comment.
Nit: just for readability should this be set after the event is sent? This is a very small thing admittedly, but I ended up reading through those 2 lines several times to understand then realized it made sense after reading the rest.
mzlangreder
approved these changes
Sep 2, 2026
saralvasquez
force-pushed
the
compose-analytics
branch
2 times, most recently
from
September 4, 2026 00:00
51ee071 to
287ffc2
Compare
saralvasquez
force-pushed
the
compose-analytics
branch
from
September 4, 2026 16:57
287ffc2 to
2b7c912
Compare
Base automatically changed from
compose-pay-support
to
card-fields-compose-feature
September 4, 2026 22:56
saralvasquez
force-pushed
the
compose-analytics
branch
from
September 4, 2026 22:56
2b7c912 to
0ac0b00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
AI Usage
Which AI Agent Was Used?
How was AI used?
Used claude to update unit tests
Estimated AI Code Contribution
Checklist
Authors