Skip to content

Initial-value race in AsyncStream+Continuation can deliver a stale snapshot after a live update #15

Description

@leogdion

Bug

AsyncStream.init(register:unregister:initialValue:) (Sources/SundialKitStream/AsyncStream+Continuation.swift) registers the continuation and yields the initial snapshot inside an unstructured Task:

  1. register(id, cont) completes — the continuation is now live and receives manager yields.
  2. initialValue() is awaited, reads current state, and yields it.

Between steps 1 and 2 (or between the state read and the yield), a live update can be yielded by the state manager. The stale initial snapshot then arrives after the newer live value, so a subscriber's last-seen value is wrong — e.g. reachabilityUpdates() can end on isReachable=false while the session is actually reachable.

Observed downstream in brightdigit/AtLeast as a candidate cause of "phone shows watch unreachable while the watch app is active" (see brightdigit/AtLeast — STARTING_ON_WATCH_BUG.md).

Fix direction

Make registration and the current-value yield atomic inside StreamContinuationManager (e.g. registerReachability(id:continuation:) yields the current value before returning, within actor isolation), and drop the separate initialValue closure.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions