Skip to content

Derc check match detail - #125

Merged
joshvote merged 5 commits into
mainfrom
derc-check-match-detail
Nov 5, 2026
Merged

joshvote merged 5 commits into
mainfrom
derc-check-match-detail

Conversation

@LachlanJW

@LachlanJW LachlanJW commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Metadata for debugging why there are too many DERCs found.

Rewrite validate fields usage to use get_property_changes (which supports the fuzzy match on time), and sits inside submit and refetch for step.

Simplifies some checks.

@LachlanJW
LachlanJW requested a review from joshvote November 4, 2026 22:32
@joshvote

joshvote commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

✅ Code coverage on derc-check-match-detail is at 80% (compared to main being at 80%)

🎉 No files have reduced coverage 🎉

Full Coverage Report

File Details
src/cactus_client/__init__.py ✅ 100% → 100%
src/cactus_client/action/__init__.py ✅ 27% → 27%
src/cactus_client/action/der.py ✅ 92% → 92%
src/cactus_client/action/der_controls.py ✅ 88% → 88%
src/cactus_client/action/discovery.py ✅ 79% → 79%
src/cactus_client/action/end_device.py ✅ 84% → 84%
src/cactus_client/action/forget.py ✅ 100% → 100%
src/cactus_client/action/mup.py ✅ 88% → 88%
src/cactus_client/action/noop.py ✅ 67% → 67%
src/cactus_client/action/notifications.py ✅ 91% → 91%
src/cactus_client/action/refresh_resource.py ✅ 94% → 94%
src/cactus_client/action/server.py ✅ 91% → 91%
src/cactus_client/action/simulate_client.py ✅ 40% → 40%
src/cactus_client/action/subscription.py ✅ 85% → 85%
src/cactus_client/action/wait.py ✅ 60% → 60%
src/cactus_client/admin/__init__.py ✅ 100% → 100%
src/cactus_client/admin/manager.py ✅ 45% → 45%
src/cactus_client/admin/plugins.py ✅ 100% → 100%
src/cactus_client/check/__init__.py ✅ 26% → 26%
src/cactus_client/check/der.py ✅ 96% → 96%
src/cactus_client/check/der_controls.py ✅ 77% → 77%
src/cactus_client/check/discovered.py ✅ 98% → 98%
src/cactus_client/check/end_device.py ✅ 99% → 99%
src/cactus_client/check/function_set_assignment.py ✅ 97% → 97%
src/cactus_client/check/mup.py ✅ 95% → 95%
src/cactus_client/check/sep2.py ✅ 96% → 96%
src/cactus_client/check/time.py ✅ 98% → 98%
src/cactus_client/cli/__init__.py ✅ 100% → 100%
src/cactus_client/cli/common.py ✅ 26% → 26%
src/cactus_client/cli/run.py ✅ 45% → 45%
src/cactus_client/constants.py ✅ 100% → 100%
src/cactus_client/error.py ✅ 100% → 100%
src/cactus_client/execution/__init__.py ✅ 100% → 100%
src/cactus_client/execution/admin_instruction_text.py ✅ 98% → 98%
src/cactus_client/execution/build.py ✅ 85% → 85%
src/cactus_client/execution/connect.py ✅ 88% → 88%
src/cactus_client/execution/execute.py ✅ 97% → 97%
src/cactus_client/execution/keypress.py ✅ 44% → 44%
src/cactus_client/execution/run.py ✅ 26% → 26%
src/cactus_client/execution/tui.py ✅ 21% → 21%
src/cactus_client/model/__init__.py ✅ 100% → 100%
src/cactus_client/model/config.py ✅ 94% → 94%
src/cactus_client/model/context.py ✅ 98% → 98%
src/cactus_client/model/execution.py ✅ 98% → 98%
src/cactus_client/model/http.py ✅ 100% → 100%
src/cactus_client/model/output.py ✅ 90% → 90%
src/cactus_client/model/parameter.py ✅ 65% → 65%
src/cactus_client/model/progress.py ✅ 99% → 99%
src/cactus_client/model/resource.py ✅ 97% → 97%
src/cactus_client/results/__init__.py ✅ 100% → 100%
src/cactus_client/results/common.py ✅ 100% → 100%
src/cactus_client/results/compliance.py ✅ 94% → 94%
src/cactus_client/results/console.py ✅ 85% → 85%
src/cactus_client/results/requests.py ✅ 26% → 26%
src/cactus_client/schema/__init__.py ✅ 100% → 100%
src/cactus_client/schema/csipaus12/__init__.py ✅ 100% → 100%
src/cactus_client/schema/validator.py ✅ 95% → 95%
src/cactus_client/sep2.py ✅ 98% → 98%
src/cactus_client/time.py ✅ 71% → 71%
TOTAL ✅ 80% → 80%

@joshvote

joshvote commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✅ Code coverage on derc-check-match-detail is at 80% (compared to main being at 80%)

🎉 No files have reduced coverage 🎉

Full Coverage Report

File Details
src/cactus_client/__init__.py ✅ 100% → 100%
src/cactus_client/action/__init__.py ✅ 27% → 27%
src/cactus_client/action/der.py ✅ 92% → 94%
src/cactus_client/action/der_controls.py ✅ 88% → 88%
src/cactus_client/action/discovery.py ✅ 79% → 79%
src/cactus_client/action/end_device.py ✅ 84% → 84%
src/cactus_client/action/forget.py ✅ 100% → 100%
src/cactus_client/action/mup.py ✅ 88% → 88%
src/cactus_client/action/noop.py ✅ 67% → 67%
src/cactus_client/action/notifications.py ✅ 91% → 91%
src/cactus_client/action/refresh_resource.py ✅ 94% → 94%
src/cactus_client/action/server.py ✅ 91% → 91%
src/cactus_client/action/simulate_client.py ✅ 40% → 40%
src/cactus_client/action/subscription.py ✅ 85% → 85%
src/cactus_client/action/wait.py ✅ 60% → 60%
src/cactus_client/admin/__init__.py ✅ 100% → 100%
src/cactus_client/admin/manager.py ✅ 45% → 45%
src/cactus_client/admin/plugins.py ✅ 100% → 100%
src/cactus_client/check/__init__.py ✅ 26% → 26%
src/cactus_client/check/der.py ✅ 96% → 96%
src/cactus_client/check/der_controls.py ✅ 77% → 77%
src/cactus_client/check/discovered.py ✅ 98% → 98%
src/cactus_client/check/end_device.py ✅ 99% → 99%
src/cactus_client/check/function_set_assignment.py ✅ 97% → 97%
src/cactus_client/check/mup.py ✅ 95% → 95%
src/cactus_client/check/sep2.py ✅ 96% → 96%
src/cactus_client/check/time.py ✅ 98% → 98%
src/cactus_client/cli/__init__.py ✅ 100% → 100%
src/cactus_client/cli/common.py ✅ 26% → 26%
src/cactus_client/cli/run.py ✅ 45% → 45%
src/cactus_client/constants.py ✅ 100% → 100%
src/cactus_client/error.py ✅ 100% → 100%
src/cactus_client/execution/__init__.py ✅ 100% → 100%
src/cactus_client/execution/admin_instruction_text.py ✅ 98% → 98%
src/cactus_client/execution/build.py ✅ 85% → 85%
src/cactus_client/execution/connect.py ✅ 88% → 88%
src/cactus_client/execution/execute.py ✅ 97% → 97%
src/cactus_client/execution/keypress.py ✅ 44% → 44%
src/cactus_client/execution/run.py ✅ 26% → 26%
src/cactus_client/execution/tui.py ✅ 21% → 21%
src/cactus_client/model/__init__.py ✅ 100% → 100%
src/cactus_client/model/config.py ✅ 94% → 94%
src/cactus_client/model/context.py ✅ 98% → 98%
src/cactus_client/model/execution.py ✅ 98% → 98%
src/cactus_client/model/http.py ✅ 100% → 100%
src/cactus_client/model/output.py ✅ 90% → 90%
src/cactus_client/model/parameter.py ✅ 65% → 65%
src/cactus_client/model/progress.py ✅ 99% → 99%
src/cactus_client/model/resource.py ✅ 97% → 97%
src/cactus_client/results/__init__.py ✅ 100% → 100%
src/cactus_client/results/common.py ✅ 100% → 100%
src/cactus_client/results/compliance.py ✅ 94% → 94%
src/cactus_client/results/console.py ✅ 85% → 85%
src/cactus_client/results/requests.py ✅ 26% → 26%
src/cactus_client/schema/__init__.py ✅ 100% → 100%
src/cactus_client/schema/csipaus12/__init__.py ✅ 100% → 100%
src/cactus_client/schema/validator.py ✅ 95% → 95%
src/cactus_client/sep2.py ✅ 98% → 98%
src/cactus_client/time.py ✅ 71% → 71%
TOTAL ✅ 80% → 80%

@joshvote
joshvote merged commit 4e5e1d6 into main Nov 5, 2026
6 checks passed
@joshvote
joshvote deleted the derc-check-match-detail branch November 5, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants